ci: added ping-for-attention command to notify the reviewers #239
Conversation
Priyansh61
requested review from
derberg,
quetzalliwrites,
fmvilas,
KhudaDad414 and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
@Priyansh61 please engage with the community in clack in contributing channel. Explain the goal of your command and ask what they thing about this command, if this is ok name that you put here or maybe there have better ideas in the meantime please update |
Priyansh61
changed the title
|
This will be useful for people like me 😅 |
.github/workflows/help-command.yml
Outdated
| @@ -33,7 +33,11 @@ jobs: | |||
|
|
|||
| - `/ready-to-merge` or `/rtm` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added | |||
| - `/do-not-merge` or `/dnm` - This comment will block automerging even if all conditions are met and ready-to-merge label is added | |||
| - `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR.` | |||
| - `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR. | |||
| - `/ping-for-attention` or `/pfa` or `/ptal` - This comment will add a comment to the PR asking for attention from the reviewrs who have not reviewed the PR yet. | |||
There was a problem hiding this comment.
I think we should just go with one way, and ptal is the best one as it is known short, just do ptal and longer version which probably is something like please take a look (probably something to check with urban dictionary)
There was a problem hiding this comment.
@Priyansh61 hey, you added to help command info about rerequest and review but the PR contains only support for ptal 🤔
|
unless the plan is to have it here, to not add it in https://github.com/asyncapi/.github/pull/243/files to not face merge conflicts later? so we basically wait for #243 until it is approved and we merge both PRs together? @KhudaDad414 as you were in review when I was out, did you discuss that these new workflows need to be added to https://github.com/asyncapi/.github/blob/master/.github/workflows/global-replicator.yml#L141? |
|
@derberg my bad, totally forgot that. 🤦 |
|
@KhudaDad414 since a lot for work is done, but contributor is not around, maybe you can just commit directly to his for what is missing and we can merge? |
|
/rtm |
KhudaDad414
changed the title
Description
The PR adds the functionality to use
/pfaor/ping-for-attention.The functionality is achieved by
Proof of Work
ping-for-attention-2023-05-18_20.53.51.mp4
Related issue(s)
Resolves #211