-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add update-docs workflow #258
Conversation
use commits instead of tags as they are not vulnerable to any bad actors activity (removal of tag, or recreating tag that points to code that sneaks out the api keys) Co-authored-by: Animesh Kumar <[email protected]>
Co-authored-by: Animesh Kumar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
I remembered the suggestion made by Lukasz in my PR a long time ago so thought that it should apply here as well. 😁
Rest of the code I'm not an expert so I leave it to other maintainers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, thanks a lot for this contribution 🍻
Also please add failure handling https://github.com/derberg/website-asyncapi/blob/refackdsrfssd/.github/workflows/regenerate-meetings-and-videos.yml#L49
* topic changed to get-global-docs-autoupdate
All the required changed are done @derberg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/rtm |
just tried it, works like a charm, all repos that had its own copy, now have the global version one tiny issue: readme is not updated https://github.com/asyncapi/.github 😄 |
I will update the README and send a new PR. 😸 |
Description
Related issue(s)
Fixes #242