-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove deprecated import #775
Conversation
changed simple-git/promise with just simple-git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Kudos, SonarCloud Quality Gate passed! |
@pavlikm Hello! Thanks for contribution! Please follow by PR title rules: https://github.com/asyncapi/.github/blob/master/CONTRIBUTING.md#conventional-commits |
hmmm... I do not think we have an integration test that covers the functionality provided by |
@derberg it is based on error showed on start of application using this generator:
|
@pavlikm I'm not questioning if it is needed, just want to make sure it still works 😄 just run generation on local and point output to folder with |
@derberg yes, if it should show me error about unstaged changes, then it works well:
the only difference against master is, that info pasted in my previous comment is missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @magicmatatjahu anything from you?
@derberg It's ok. |
/rtm |
🎉 This PR is included in version 1.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #770