Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not register a ts-node when an instance is already registered #764

Merged
merged 2 commits into from
Apr 5, 2022
Merged

fix: do not register a ts-node when an instance is already registered #764

merged 2 commits into from
Apr 5, 2022

Conversation

magicmatatjahu
Copy link
Member

Description

As in title: if the ts-node has already been registered before, do not register it again.

Related issue(s)
Fixes #759

@magicmatatjahu magicmatatjahu added the bug Something isn't working label Mar 29, 2022
@magicmatatjahu magicmatatjahu mentioned this pull request Mar 29, 2022
Closed
@jonaslagoni
Copy link
Member

The tests seem to fail 🙂

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

derberg
derberg approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests seem to pass after update to latest master

@magicmatatjahu
Copy link
Member Author

@derberg Thanks!

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @magicmatatjahu! 👋🏼
This PR is not up to date with the base branch and can't be merged.
You can add comment to this PR with text: /autoupdate or /au. This way you ask our bot to perform regular updates for you. The only requirement for this to work is to enable Allow edits from maintainers option in your PR. Otherwise the only option that you have is to manually update your branch with latest version of the base branch.
Thanks 😄

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 54c75c2 into asyncapi:master Apr 5, 2022
@asyncapi-bot
Copy link
Contributor

Hello, @magicmatatjahu! 👋🏼
This PR is not up to date with the base branch and can't be merged.
You can add comment to this PR with text: /autoupdate or /au. This way you ask our bot to perform regular updates for you. The only requirement for this to work is to enable Allow edits from maintainers option in your PR. Otherwise the only option that you have is to manually update your branch with latest version of the base branch.
Thanks 😄

@magicmatatjahu magicmatatjahu deleted the fix/ts-node-reregister-bug branch April 5, 2022 13:17
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use async-api generator in projects that use ts-node
4 participants
@magicmatatjahu @jonaslagoni @asyncapi-bot @derberg