feat: add core message payload validation #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaslagoni
requested review from
fmvilas,
derberg,
dalelane,
smoya,
char0n and
asyncapi-bot-eve
as code owners
jonaslagoni
commented
Mar 13, 2023
Comment on lines
+148
to
+150
| "application/vnd.aai.asyncapi;version=2.0.0", | ||
| "application/vnd.aai.asyncapi+json;version=2.0.0", | ||
| "application/vnd.aai.asyncapi+yaml;version=2.0.0" |
There was a problem hiding this comment.
Should v2.0.0 add support for up until v2.6.0? 🤔
There was a problem hiding this comment.
That's actually a really good point 🤔.
Sticking to AsyncAPI docs, I understand we don't as we don't mention any other allowed values than the current Schema for the current version.
dalelane
approved these changes
Mar 13, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks for the reviews folks 🎉 |
|
/rtm |
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0-next-major-spec.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was initially added to v3 here: #334
This PR replicates it for v2.