Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update references for avro and openapi schema #395

Merged
merged 5 commits into from
May 30, 2023

Conversation

derberg
Copy link
Member

@derberg derberg commented May 24, 2023

autocompletion in IDEs is affected

Screenshot 2023-05-24 at 09 19 10

some more rewriting in refs in the dedicated JSON Schema was needed

  • schemas content is generated, you can skip review of this one
  • added test/fixtures/asyncapi.yml to make it easier long term to test schemas on local, readme also updated
  • main magic changes in index.js

@derberg
Copy link
Member Author

derberg commented May 24, 2023

since @fmvilas and @smoya are out, I'm counting on you guys @dalelane @char0n 👀

dalelane
dalelane previously approved these changes May 26, 2023
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one stylistic question, but otherwise looks good 👍

README.md Outdated Show resolved Hide resolved
test/fixtures/asyncapi.yml Outdated Show resolved Hide resolved
Copy link
Member Author

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalelane removed wookiee 😄 please have another look

@derberg derberg requested a review from dalelane May 29, 2023 14:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@derberg
Copy link
Member Author

derberg commented May 30, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit d7cd444 into asyncapi:master May 30, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants