chore: update instructions for some tools promotion usage #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derberg
requested review from
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
derberg
commented
Nov 8, 2023
| @@ -11,7 +11,6 @@ import { | |||
| import CodeBlock from '../../components/editor/CodeBlock'; | |||
| import Heading from '../../components/typography/Heading'; | |||
| import Paragraph from '../../components/typography/Paragraph'; | |||
| import DocsButton from '../../components/buttons/DocsButton'; | |||
There was a problem hiding this comment.
never used here, not for tools, it is used in docs
derberg
commented
Nov 8, 2023
Comment on lines
+30
to
+31
| return `npm install -g @asyncapi/cli | ||
| asyncapi generate fromTemplate ${specPath} ${template} ${params}` |
There was a problem hiding this comment.
not much v3 related but I could not stand it is so outdated 😄
akshatnema
requested changes
Nov 8, 2023
|
@akshatnema current version is also highlighting weird, for me separate issue from this PR |
akshatnema
approved these changes
Nov 9, 2023
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1854