Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification trigger attributes to inherit from WaitingTriggerAttribute #548

Closed
YevgeniyShunevych opened this issue Sep 16, 2021 · 0 comments
Assignees
Milestone

Comments

@YevgeniyShunevych
Copy link
Member

The following trigger attributes should inherit from WaitingTriggerAttribute instead of base TriggerAttribute:

  • VerifyTitleAttribute
  • VerifyH1Attribute - VerifyH6Attribute
  • VerifyExistsAttribute
  • VerifyMissingAttribute
  • VerifyContentAttribute
  • VerifyContentMatchesAttribute

Now the above attributes will get Timeout and RetryInterval properties from WaitingTriggerAttribute that they should use for verification. So the user will be able to set one or both of these properties to, for example, increase the verification time for slow pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant