Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Replace deprecated linters: maligned, scopelint #218

Closed
atc0005 opened this issue Apr 9, 2021 · 0 comments · Fixed by #219
Closed

Replace deprecated linters: maligned, scopelint #218

atc0005 opened this issue Apr 9, 2021 · 0 comments · Fixed by #219
Assignees
@atc0005
Labels
bug Something isn't working linting
Milestone
v0.4.11

Comments

@atc0005
Copy link
Owner

atc0005 commented Apr 9, 2021

Linters:

brick/.golangci.yml

Line 42 in 0ccc284

- scopelint

brick/.golangci.yml

Line 36 in 0ccc284

- maligned

See these issues for more info:
@atc0005 atc0005 added bug Something isn't working linting labels Apr 9, 2021
@atc0005 atc0005 added this to the Next Release milestone Apr 9, 2021
@atc0005 atc0005 self-assigned this Apr 9, 2021
atc0005 added a commit that referenced this issue Apr 9, 2021
@atc0005
Replace deprecated linters
33f0d1a 
- replace deprecated `maligned` linter with
  `govet: fieldalignment`
- replace deprecated `scopelint` linter with
  `exportloopref`

refs GH-218
@atc0005 atc0005 mentioned this issue Apr 9, 2021
Merged
atc0005 added a commit that referenced this issue Apr 15, 2021
@atc0005
Re-enable deprecated maligned linter
17258fa 
Disable govet:fieldalignment, re-enable deprecated maligned
linter until the Go team offers more control over the types
of checks provided by the fieldalignment linter or
golangci-lint does so.

refs GH-218
refs GH-219
refs GH-220
refs atc0005/go-ci#302
atc0005 added a commit that referenced this issue Apr 15, 2021
@atc0005
Re-enable deprecated maligned linter
0058ec9 
Disable govet:fieldalignment, re-enable deprecated maligned
linter until the Go team offers more control over the types
of checks provided by the fieldalignment linter or
golangci-lint does so.

- refs GH-218
- refs GH-219
- refs GH-220
- refs atc0005/go-ci#302
@atc0005 atc0005 mentioned this issue Apr 15, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atc0005 atc0005

Labels
bug Something isn't working linting
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging a pull request may close this issue.

Replace deprecated linters atc0005/brick
1 participant
@atc0005