Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fieldalignment: struct with X pointer bytes could be Y (govet) #204

Closed
atc0005 opened this issue Apr 2, 2021 · 0 comments · Fixed by #205
Closed

fieldalignment: struct with X pointer bytes could be Y (govet) #204

atc0005 opened this issue Apr 2, 2021 · 0 comments · Fixed by #205
Assignees
@atc0005
Labels
bug Something isn't working linting
Milestone
v0.15.2

Comments

@atc0005
Copy link
Owner

atc0005 commented Apr 2, 2021

Multiple linting issues exposed by the changes in GH-203:

Running linting tools ...
Running go vet ...
Running golangci-lint ...
internal/config/config.go:93:13: fieldalignment: struct with 616 pointer bytes could be 408 (govet)
type Config struct {
            ^
internal/vsphere/host-to-datastores.go:45:46: fieldalignment: struct with 32 pointer bytes could be 24 (govet)
type ErrHostDatastoreIdxIDToNameLookupFailed struct {
                                             ^
internal/vsphere/snapshots.go:107:22: fieldalignment: struct with 96 pointer bytes could be 80 (govet)
type SnapshotSummary struct {
                     ^
make: *** [Makefile:131: linting] Error 1
Error: Process completed with exit code 2.
@atc0005 atc0005 added bug Something isn't working linting labels Apr 2, 2021
@atc0005 atc0005 added this to the Next Release milestone Apr 2, 2021
@atc0005 atc0005 self-assigned this Apr 2, 2021
atc0005 added a commit that referenced this issue Apr 2, 2021
@atc0005
Fix govet:fieldalignment linting errors
e110401 
Change field order of affected structs in order to reduce
allocation requirements and pass `fieldalignment` linting check.

refs GH-204
@atc0005 atc0005 mentioned this issue Apr 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working linting
Projects
None yet
Milestone
v0.15.2
Development

Successfully merging a pull request may close this issue.

Fix govet:fieldalignment linting errors atc0005/check-vmware
1 participant
@atc0005