Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fieldalignment: struct with X pointer bytes could be Y (govet) #141

Closed
atc0005 opened this issue Apr 8, 2021 · 0 comments · Fixed by #143
Closed

fieldalignment: struct with X pointer bytes could be Y (govet) #141

atc0005 opened this issue Apr 8, 2021 · 0 comments · Fixed by #143
Assignees
@atc0005
Labels
bug Something isn't working linting
Milestone
v0.4.12

Comments

@atc0005
Copy link
Owner

atc0005 commented Apr 8, 2021

Linting issue exposed by the changes in atc0005/go-ci#287 and atc0005/go-ci#288:

internal/config/config.go:71:13: fieldalignment: struct with 104 pointer bytes could be 88 (govet)
type Config struct {
            ^
@atc0005 atc0005 added bug Something isn't working linting labels Apr 8, 2021
@atc0005 atc0005 added this to the Next Release milestone Apr 8, 2021
@atc0005 atc0005 self-assigned this Apr 8, 2021
atc0005 added a commit that referenced this issue Apr 8, 2021
@atc0005
Fix govet:fieldalignment linting error
70dc2de 
Change field order of `Config` struct to reduce allocation
requirements and pass `fieldalignment` linting check.

refs GH-141
@atc0005 atc0005 mentioned this issue Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working linting
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging a pull request may close this issue.

Fix govet:fieldalignment linting error atc0005/send2teams
1 participant
@atc0005