Merge pull request #41 from Istaroth/coolcover

Remove unnecessary stop before up/down
athombv · Dec 3, 2024 · 95b11c6 · 95b11c6
2 parents 218cb6b + abdd654
commit 95b11c6
Showing 1 changed file with 0 additions and 7 deletions.
diff --git a/drivers/knx_windowcoverings/device.js b/drivers/knx_windowcoverings/device.js
@@ -46,10 +46,6 @@ class KNXWindowCovering extends KNXGenericDevice {
     if (this.knxInterface) {
       switch (value) {
         case 'up':
-          if (this.settings.ga_stop) {
-            this.knxInterface.writeKNXGroupAddress(this.settings.ga_stop, 0, 'DPT1');
-          }
-
           if (this.settings.invert_updown === true) {
             return this.knxInterface.writeKNXGroupAddress(this.settings.ga_up_down, 1, 'DPT1')
               .catch((knxerror) => {
@@ -61,9 +57,6 @@ class KNXWindowCovering extends KNXGenericDevice {
               throw new Error(this.homey.__('errors.windowcovering_failed'), knxerror);
             });
         case 'down':
-          if (this.settings.ga_stop) {
-            this.knxInterface.writeKNXGroupAddress(this.settings.ga_stop, 0, 'DPT1');
-          }
           if (this.settings.invert_updown === true) {
             return this.knxInterface.writeKNXGroupAddress(this.settings.ga_up_down, 0, 'DPT1')
               .catch((knxerror) => {