fix: paypal tokens request requires encoded redirect_uri
#157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR re-adds the
encodeURIComponent
to theredirect_uri
when fetching tokens.I noticed the utils refactor in #147 broke PayPal login because the
redirect_uri
encode was removed, I should have left a comment in the code when I made the PayPal provider PR (#108) saying that at the moment PayPal login for some reason requires encoding theredirect_uri
when fetching the tokens.For testing:
REST API apps
Click onDefault Application
Client ID
andSecret key 1
.env
file and add the credentials respectivelyNUXT_OAUTH_PAYPAL_CLIENT_ID
andNUXT_OAUTH_PAYPAL_CLIENT_SECRET
Features
section, and enableLog in with PayPal
Advanced Settings
link below theLog in with PayPal
checkboxReturn URL
tohttp://127.0.0.1:3000/auth/paypal
Full Name
andEmail
Enable customers who have not yet confirmed their email with PayPal to log in to your app.