Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(steam): improve open id validation #184

Merged
merged 6 commits into from
Sep 23, 2024
Merged

fix(steam): improve open id validation #184

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7ac73ee
fix(steam): open id validation
ahmedrangel Sep 20, 2024
cb76c16
chore: lint
ahmedrangel Sep 20, 2024
f9823b2
chore: check steam id
ahmedrangel Sep 20, 2024
279f00c
[autofix.ci] apply automated fixes
autofix-ci[bot] Sep 20, 2024
c4a8fd4
chore: update error message
ahmedrangel Sep 21, 2024
0cf1e5c
chore: adjust steam id checker
ahmedrangel Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions src/runtime/server/lib/oauth/steam.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,22 +51,31 @@ export function oauthSteamEventHandler({ config, onSuccess, onError }: OAuthConf
return sendRedirect(event, withQuery(config.authorizationURL as string, steamOpenIdParams))
}

// Validate OpenID Authentication
const validateAuth: string = await $fetch(withQuery(config.authorizationURL as string, {
...query,
'openid.mode': 'check_authentication',
}))
const openIdCheck = {
ns: 'http://specs.openid.net/auth/2.0',
claimed_id: 'https://steamcommunity.com/openid/id/',
identity: 'https://steamcommunity.com/openid/id/',
}

const idRegex = /^https?:\/\/steamcommunity\.com\/openid\/id\/(\d+)$/
const steamIdCheck = idRegex.exec(query['openid.claimed_id'])

if (!validateAuth.includes('is_valid:true')) {
if (
query['openid.op_endpoint'] !== config.authorizationURL
|| !steamIdCheck
|| query['openid.ns'] !== openIdCheck.ns
|| !query['openid.claimed_id']?.startsWith(openIdCheck.claimed_id)
|| !query['openid.identity']?.startsWith(openIdCheck.identity)
) {
const error = createError({
statusCode: 401,
message: 'Steam login failed: Unknown error',
message: 'Steam login failed: Claimed identity is invalid.',
})
if (!onError) throw error
return onError(event, error)
}

const steamId = query['openid.claimed_id'].split('/').pop()
const steamId = steamIdCheck[1]

// TODO: improve typing
// eslint-disable-next-line @typescript-eslint/no-explicit-any
Expand Down