Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch hook is called even is user is not set #209

Merged
merged 2 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/runtime/server/api/session.get.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import { eventHandler } from 'h3'
import { getUserSession, sessionHooks } from '../utils/session'
import type { UserSessionRequired } from '#auth-utils'

export default eventHandler(async (event) => {
const session = await getUserSession(event)

// If session is not empty, call fetch hook
if (Object.keys(session).length > 0) {
await sessionHooks.callHookParallel('fetch', session as UserSessionRequired, event)
await sessionHooks.callHookParallel('fetch', session, event)
}

const { secure, ...data } = session
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/server/utils/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export interface SessionHooks {
* - Add extra properties to the session
* - Throw an error if the session could not be verified (with a database for example)
*/
fetch: (session: UserSessionRequired, event: H3Event) => void | Promise<void>
fetch: (session: UserSession, event: H3Event) => void | Promise<void>
/**
* Called before clearing the session
*/
Expand Down