This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
[MRG] Fixed #343: Use @group(name=) instead of overriding HelpFormater.write_usage #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitern
changed the title
|
@vinayak-mehta Hey, it looks like the repository has been renamed from |
|
It has been renamed back for now. Thanks for raising this PR! Please give me some time to review and merge it :) |
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 87.64% 87.64%
=======================================
Files 13 13
Lines 1505 1505
Branches 348 348
=======================================
Hits 1319 1319
Misses 129 129
Partials 57 57
Continue to review full report at Codecov.
|
|
Closing in favour of camelot-dev/camelot#5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #343
In order not to show
camelotas the program name in the help output (passing--help), it's enough to set@group(name='camelot')on the main Click group for the CLI. The existing approach which monkey patchesclick.HelpFormatter.write_usage(), will affect any other Click CLI tool that usescamelotas its dependency, e.g. Excalibur.Added a test to verify it works as expected in the help output.