fix: Update project directory create project button selector #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackheart-atlassian
force-pushed
the
BLU-000-update-project-directory-selector
branch
from
f917f6a
to
8941477
Compare
joshkay10
approved these changes
Apr 11, 2023
|
@blackheart-atlassian if you can fix the failed push / build check we'll be able to approve this and get it merged in. |
| await (page.locator("button[data-test-id='global-pages.directories.projects-directory-v2.create-projects-button.button.button']")).click(); | ||
| const createProjectButtonV3 = page.locator("button[data-testid='global-pages.directories.projects-directory-v3.create-projects-button']"); | ||
| if (await createProjectButtonV3.isVisible()) { | ||
| createProjectButtonV3.click() |
There was a problem hiding this comment.
Suggested change
| createProjectButtonV3.click() | |
| await createProjectButtonV3.click(); |
|
Hmm, I don't get how to resolve the conflicts. Need some helps :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
e2e test update to conditionally check which version of project create button is present on the page.
Why
We're updating projects directory button selector as we're rolling out new experience.
Added feature flags
none
Affected issues
Jira Issues
How has this been tested?
e2e