Arc 2274 analytics for spa add events #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxueatlassian
commented
Jul 26, 2023
| @@ -96,14 +96,6 @@ | |||
| "principals": [], | |||
| "allowed": true | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
I've change to use the /public/assets to load those svgs, as those are assets from public folder, it make more sense to name it like that.
krazziekay
previously approved these changes
Jul 26, 2023
spa/src/analytics/context.ts
Outdated
|
|
||
| try { | ||
|
|
||
| const jwtToken: string = await new Promise((res) => { |
There was a problem hiding this comment.
Can we reuse the getHeaders from axiosInstance? Maybe give it a different name like getAtlassianJWT.
Co-authored-by: kAy <[email protected]>
krazziekay
previously approved these changes
Jul 26, 2023
krazziekay
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Why
Added feature flags
Affected issues
ARC-2274
How has this been tested?
Whats Next?