Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INNO] ARC-2720-Adding links in spa backfill #2606

Merged
merged 10 commits into from
Dec 8, 2023
Merged

[INNO] ARC-2720-Adding links in spa backfill #2606

merged 10 commits into from
Dec 8, 2023

Conversation

sopliu
Copy link
Contributor

@sopliu sopliu commented Dec 7, 2023

What's in this PR?
Added links to backfill page:

  • Changed the All / Selected repos to a link, which on clicking shows the list of all the repos.
  • Added a pencil icon and link it to the Github app settings and permission
  • Added a settings dropdown which contains a configure item that also links to Github app settings

Also the beginnings of a repositories page which isn't currently being used

Why
Innovation week

Screenshot

  • Changed text to link, added pencil icon and adding settings column with dropdown
image - Opened dropdown image

Whats Next?
Fully building out the repositories page

@sopliu sopliu self-assigned this Dec 7, 2023
@sopliu sopliu requested a review from a team as a code owner December 7, 2023 05:59
@sopliu sopliu changed the title Arc 2720 adding links in spa backfill ARC-2720-Adding links in spa backfill Dec 7, 2023
@sopliu sopliu changed the title ARC-2720-Adding links in spa backfill [INNO] ARC-2720-Adding links in spa backfill Dec 7, 2023
krazziekay
krazziekay requested changes Dec 7, 2023
View reviewed changes
spa/src/app.tsx Outdated Show resolved Hide resolved
spa/src/utils/dynamicTableHelper.tsx Outdated Show resolved Hide resolved
krazziekay
krazziekay approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@krazziekay krazziekay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

@krazziekay krazziekay merged commit c6020bb into main Dec 8, 2023
4 of 5 checks passed
@krazziekay krazziekay deleted the ARC-2720-adding-links-in-spa-backfill branch December 8, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamaksheeAtl kamaksheeAtl kamaksheeAtl left review comments

@krazziekay krazziekay krazziekay approved these changes

Assignees

@sopliu sopliu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sopliu @krazziekay @kamaksheeAtl