Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arc 2777 reactify GHE backfill pg #2620

Merged
merged 16 commits into from
Jan 3, 2024
Merged

Arc 2777 reactify GHE backfill pg #2620

merged 16 commits into from
Jan 3, 2024

Conversation

kamaksheeAtl
Copy link
Contributor

@kamaksheeAtl kamaksheeAtl commented Dec 27, 2023 •
edited
Loading

What's in this PR?
https://softwareteams.atlassian.net/browse/ARC-2777

  1. Add an option to Connect a GitHub organization to GHE server app.
Screen.Recording.2023-12-27.at.9.48.57.pm.mov
  1. Add a button for disconnecting a GHE server.
Screen.Recording.2023-12-27.at.9.53.52.pm.mov
  1. GHE server app organisation action menu

Uploading Screen Recording 2023-12-27 at 9.51.15 pm.mov…

@kamaksheeAtl kamaksheeAtl requested a review from a team as a code owner December 27, 2023 12:51
@kamaksheeAtl kamaksheeAtl marked this pull request as draft December 27, 2023 12:52
@kamaksheeAtl kamaksheeAtl marked this pull request as ready for review January 1, 2024 22:11
gxueatlassian
gxueatlassian reviewed Jan 1, 2024
View reviewed changes
spa/src/pages/Connections/Modals/DisconnectGHEServerModal.tsx Outdated Show resolved Hide resolved
spa/src/pages/Connections/Modals/DisconnectSubscriptionModal.tsx Outdated Show resolved Hide resolved
src/rest/rest-router.ts Outdated Show resolved Hide resolved
src/rest/rest-router.ts Outdated Show resolved Hide resolved
src/rest/routes/enterprise/delete-ghe-server.ts Outdated Show resolved Hide resolved
gxueatlassian
gxueatlassian requested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@gxueatlassian gxueatlassian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll pop in another PR prior to this to unblock this.

@kamaksheeAtl kamaksheeAtl merged commit 3bb9839 into main Jan 3, 2024
4 of 5 checks passed
@kamaksheeAtl kamaksheeAtl deleted the ARC-2777-Reactify-GHE-backfill-pg branch January 3, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krazziekay krazziekay krazziekay left review comments

@gxueatlassian gxueatlassian gxueatlassian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamaksheeAtl @krazziekay @gxueatlassian