Clarify some stuff

atlassian · Sep 7, 2021 · 5ac61c8 · 5ac61c8
1 parent aac4c1f
commit 5ac61c8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/pb/remote_write.proto b/pb/remote_write.proto
@@ -2,6 +2,8 @@ syntax = "proto3";
 
 package pb;
 
+// https://docs.google.com/document/d/1LPhVRSFkGNSuU1fBd81ulhsCPR4hkSZyyBj1SZ8fWOM/
+
 message PromWriteRequest {
   repeated PromTimeSeries timeseries = 1;
   // Cortex uses this field to determine the source of the write request.

diff --git a/pkg/backends/datadog/flush.go b/pkg/backends/datadog/flush.go
@@ -16,6 +16,11 @@ const (
 	rate metricType = "rate"
 	// counter is a datadog counter type.
 	counter metricType = "count"
+
+	// We want to ensure we don't go over any limits, in case they're
+	// hard limits so we flush when we get *near* the limit, with the
+	// goal of never going *over* the limit.
+	flushBuffer = 20
 )
 
 // flush represents a send operation.
@@ -77,7 +82,7 @@ func coerceToNumeric(v float64) float64 {
 }
 
 func (f *flush) maybeFlush() {
-	if uint(len(f.ts.Series))+20 >= f.metricsPerBatch { // flush before it reaches max size and grows the slice
+	if uint(len(f.ts.Series))+flushBuffer >= f.metricsPerBatch { // flush before it reaches max size and grows the slice
 		f.cb(f.ts)
 		f.ts = &timeSeries{
 			Series: make([]metric, 0, f.metricsPerBatch),