Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve internal observability when running in forwarder mode #629

Merged
merged 7 commits into from
Jul 31, 2023

Conversation

MovieStoreGuy
Copy link
Contributor

Context

When running a large deployment, it is possible that the internal metrics can contribute a significant amount of traffic just at idle.

Changes

  • Added a feature to disable internal events
  • Changed a subset of internal metrics to be non cumulative counters

pkg/statsd/parser.go Outdated Show resolved Hide resolved
pkg/stats/heartbeat.go Outdated Show resolved Hide resolved
METRICS.md Outdated Show resolved Hide resolved
pkg/statsd/receiver.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@tiedotguy tiedotguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdfgsdgdf

@MovieStoreGuy MovieStoreGuy merged commit 31ebc74 into master Jul 31, 2023
5 checks passed
@MovieStoreGuy MovieStoreGuy deleted the mgs/improve-forwarder-metrics branch July 31, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants