Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collect console log in renderer tests #63

Merged
merged 2 commits into from
Jul 25, 2020
Merged

collect console log in renderer tests #63

merged 2 commits into from
Jul 25, 2020

Conversation

aminya
Copy link
Member

@aminya aminya commented Jul 24, 2020

This is a patch for #50 that collects the console log and prints it at the end.

@aminya
Copy link
Member Author

aminya commented Jul 25, 2020 •
edited
Loading

@DeeDeeG turns out using async.parallel does not work well with Atom. Switching to async.series, now most of the tests pass without any issues.

We can try async.parallelLimit with which limits the number of processes that run in parallel. Setting the number to 2 may be enough for letting another process to run in case of a timeout.

aminya added 2 commits July 24, 2020 21:03
@aminya
collect console log in renderer tests
c413a56 
Print the output finally to ease diagnosing
@aminya
Use async.series
3bdd637 
Revert b61475f
@aminya aminya force-pushed the renderer_test_collect_output branch from d0519af to 3bdd637 Compare July 25, 2020 02:04
@aminya aminya merged commit 6450e5c into master Jul 25, 2020
@aminya aminya mentioned this pull request Jul 25, 2020
Closed
@aminya aminya linked an issue Jul 25, 2020 that may be closed by this pull request
Setting up Azure pipelines #1
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting up Azure pipelines
1 participant
@aminya