Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add missing subclasses to .markup and remove .gfm specific styling #444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing subclasses to .markup and remove .gfm specific styling #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions templates/theme/styles/base.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,8 @@ atom-text-editor .search-results .marker.current-result .region,
}

.markup {
-webkit-font-smoothing: auto;

&.bold {
color: @orange;
font-weight: bold;
Expand All @@ -277,6 +279,7 @@ atom-text-editor .search-results .marker.current-result .region,
font-style: italic;
}

&.heading,
&.heading .punctuation.definition.heading {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's actually an example for &.heading .punctuation.definition.heading? I can't find where that gets used. Maybe we can remove it and just have &.heading.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. Just remove it, and hope nobody notices anything?
From the default languages, the only one with .heading is markdown, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When doing a search I can only find it in this file: https://github.com/atom/language-coffee-script/blob/master/grammars/coffeescript%20(literate).cson#L131. Seems like for when Markdown is used in a CoffeeScript file? History doesn't reveal much either.

Just remove it, and hope nobody notices anything?

Yeah, I would say so. It sounds really specific for a "base" selector. And is probably used only to override .heading .something.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any spec that gives an example for this? If not, I'd say remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is https://manual.macromates.com/en/language_grammars#naming_conventions, but doesn't go deeper than .markup.heading.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take the blame if this destroys the world, okay?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 Will be fine. And we can always add it back if it's really crucial.

color: @blue;
}
Expand All @@ -285,8 +288,15 @@ atom-text-editor .search-results .marker.current-result .region,
color: @green;
}

&.link {
color: @blue;
}

&.list {
color: @red;
.punctuation,
.variable {
color: @red;
}
}

&.quote {
Expand All @@ -298,13 +308,6 @@ atom-text-editor .search-results .marker.current-result .region,
}
}

.source.gfm .markup {
-webkit-font-smoothing: auto;
&.heading {
color: @green;
}
}

atom-text-editor[mini] .scroll-view,
:host([mini]) .scroll-view {
padding-left: 1px;
Expand Down