Separate markup styles from gfm #50
Conversation
|
I think it's a good idea to make it more general and not only for https://github.com/atom/apm/blob/master/templates/theme/styles/base.less is also a good place to change it. It's the styles that get used when generating a new syntax theme in Atom. |
|
Agreed. Could you update the default syntax themes? (I think they all 'suffer' from this 'issue') |
| } | ||
| // &.list { | ||
| // color: @hue-5; | ||
| // } |
There was a problem hiding this comment.
🔥 Remove commented out lines
| &.link { | ||
| color: @hue-3; | ||
| } | ||
|
|
||
| &.heading .punctuation.definition.heading { | ||
| color: @hue-2; | ||
| } |
There was a problem hiding this comment.
Nest this block inside the &.heading { .. } block above? Thus resulting in
&.heading {
color: @hue-5;
.punctuation.definition.heading {
color: @hue-2;
}
}
|
Now that my line comments have been resolved, this looks good to me! /cc @atom/feedback |
|
NOTE: changes need to be made to other default templates as well, but I'd like to leave that up to somebody who already has all eight (?) of them forked... |
| color: @hue-3; | ||
| .list { | ||
| .variable { | ||
| color: @hue-5; |
There was a problem hiding this comment.
This seems not to be needed, since those "list variables" already get styled as stand alone .variables.
I think the whole
.list {
.variable {
color: @hue-5;
}
}can be removed.
|
@simurai was right, and I removed the obsolete selector. |
|
Looks.. good. I'll try to update all the other core themes as well. |
Separate markup styles from gfm
|
👍 |
While making
language-markdownas compatible as possible with current syntax themes, I noticed that some styling defined specific forsource.gfmmight be better off as part of the general.markupclass.I believe this change doesn't break anything, but might perhaps add some extra styling to documents that use the generic markup class. If you agree on this change, I think this should be changed in all default syntax themes. I used
one-dark-syntaxmerely as an example.One thing that I'm not 100% sure of, is the disabling of the
.markup .liststyle. In my implementation of Markdown,.listis used to describe an entire list-item, instead of just the.list .variablethat is actually meant to be targeted in the original.