eic: replace modify with write. prevent losing interrupts in intflag (#…

…739)
atsamd-rs · Jun 5, 2024 · 02dbad6 · 02dbad6
1 parent 4027f8a
commit 02dbad6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/hal/CHANGELOG.md b/hal/CHANGELOG.md
@@ -3,6 +3,7 @@
 - Allow configuring USB clock with `GenericClockController` on atsamd11
 - fix samd51j not having i2s support
 - remove i2s functionality for samd51g since it does not have it
+- Fix EIC issue leading to lost interrupts
 
 # v0.17.0
 

diff --git a/hal/src/peripherals/eic/d11/pin.rs b/hal/src/peripherals/eic/d11/pin.rs
@@ -80,7 +80,7 @@ crate::paste::item! {
         }
 
         pub fn enable_interrupt(&mut self, eic: &mut EIC) {
-            eic.eic.intenset.modify(|_, w| {
+            eic.eic.intenset.write(|w| {
                 w.[<extint $num>]().set_bit()
             });
         }
@@ -92,7 +92,7 @@ crate::paste::item! {
         }
 
         pub fn disable_interrupt(&mut self, eic: &mut EIC) {
-            eic.eic.intenclr.modify(|_, w| {
+            eic.eic.intenclr.write(|w| {
                 w.[<extint $num>]().set_bit()
             });
         }
@@ -102,7 +102,7 @@ crate::paste::item! {
         }
 
         pub fn clear_interrupt(&mut self) {
-            unsafe { &(*pac::EIC::ptr()) }.intflag.modify(|_, w| {
+            unsafe { &(*pac::EIC::ptr()) }.intflag.write(|w| {
                 w.[<extint $num>]().set_bit()
             });
         }