Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue - remove deprecated code #784

Open
3 tasks
jbeaurivage opened this issue Nov 13, 2024 · 3 comments
Open
3 tasks

Tracking issue - remove deprecated code #784

jbeaurivage opened this issue Nov 13, 2024 · 3 comments

Comments

@jbeaurivage
Copy link
Contributor

jbeaurivage commented Nov 13, 2024

This is a tracking issue for the removal of deprecated code.

  • Remove support for embedded-hal v0.2
  • Remove deprecated items in sercom::dma
  • Optionally, when Async API #635 lands, remove the spi_future module - Would appreciate @bradleyharden's input on this.
@jbeaurivage jbeaurivage changed the title Remove deprecated code - embedded-hal 0.2 Tracking issue - remove deprecated code Nov 13, 2024
@Sympatron
Copy link
Contributor

I wouldn't remove embedded-hal v0.2 just yet. It can still be useful. Maybe hiding it behind a feature for now would be enogh.

@jbeaurivage
Copy link
Contributor Author

Fine by me - out of curiosity, what would you consider a good timeline to start removing it?

@Sympatron
Copy link
Contributor

I just looked into it further and I think it's not as bad as I thought. I knew some things were missing in v1, because they couldn't settle on an API. But I think they were sufficiently useless in their current state that they probably weren't used anyway.

Some drivers might still use v0.2, but those could be easily adapted (if they are still maintained...) or you could use embedded_hal_compat.

So it's probably safe to remove v0.2 with the next minor version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants