Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update itsybitsy_m4 BSP to v2 and add SPI example. #547

Merged
merged 2 commits into from
Dec 25, 2021
Merged

Update itsybitsy_m4 BSP to v2 and add SPI example. #547

merged 2 commits into from
Dec 25, 2021

Conversation

Josfemova
Copy link
Contributor

@Josfemova Josfemova commented Dec 12, 2021 •
edited
Loading

Summary

This updates the itsybitsy_m4 bsp to the v2 APIs.

  • And SPI example using the UndocIoset2 (default IOSET used for the board in every other framework) was also added.
  • The usb_serial and dotstar examples were updated to use TimerCounter instead of deprecated SpinTimer.
  • Made some changes to the usb_serial example to fix some clippy warnings.
  • Removed pins.rs as it was no longer required.
  • The cortex-m dependency was updated to 0.7

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced (see CI or check locally)

TDHolmes
TDHolmes requested changes Dec 12, 2021
View reviewed changes
Copy link
Contributor

@TDHolmes TDHolmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing we need to align on is tier one, the rest was nit picks. Thanks for doing this!

@TDHolmes TDHolmes linked an issue Dec 12, 2021 that may be closed by this pull request
Can't configure Itsybitsy m4 default SPI with sercom::v2 (new undoc ioset perhaps?) #545
Closed
@Josfemova Josfemova changed the title Update itsybitsy_m4 BSP to v2 and add SPI example. Add UndocIoset2 Update itsybitsy_m4 BSP to v2 and add SPI example. Dec 25, 2021
@Josfemova Josfemova requested a review from TDHolmes December 25, 2021 02:35
TDHolmes
TDHolmes requested changes Dec 25, 2021
View reviewed changes
Copy link
Contributor

@TDHolmes TDHolmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tweak of the README to reflect the actual changes then I'll merge and publish!

boards/itsybitsy_m4/CHANGELOG.md Outdated Show resolved Hide resolved
@TDHolmes TDHolmes merged commit 6fbaf6f into atsamd-rs:master Dec 25, 2021
@TDHolmes
Copy link
Contributor

published! thanks

@Josfemova Josfemova deleted the working_branch branch December 25, 2021 22:44
@javiser javiser mentioned this pull request Dec 28, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDHolmes TDHolmes TDHolmes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't configure Itsybitsy m4 default SPI with sercom::v2 (new undoc ioset perhaps?)
2 participants
@Josfemova @TDHolmes