Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait at end of ehal 0.2 blocking SPI writes #743

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

ianrrees
Copy link
Contributor

Summary

Discovered while tracking down an issue with the PyGamer display identified here - basically for non-duplex SPIs, the embedded-hal 0.2 blocking writes were returning as soon as the last word was written to the SERCOM, not waiting until it had been shifted out. This resulted in the command/data line for the LCD controller being toggled out of sync with the SPI data stream.

I've tested this only with the PyGamer example.

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced - CI will deny clippy warnings by default! You may #[allow] certain lints where reasonable, but ideally justify those with a short comment.

@sajattack
Copy link
Member

clippy's a little bit unhappy with this, but once you resolve that it should be good to go.

@ianrrees ianrrees force-pushed the ehal02-spi-blocking branch 2 times, most recently from b05fa9e to 19734e0 Compare August 21, 2024 10:22
@ianrrees ianrrees force-pushed the ehal02-spi-blocking branch from 19734e0 to 8908e8c Compare August 21, 2024 10:29
@ianrrees ianrrees merged commit 3d2ba76 into atsamd-rs:master Aug 21, 2024
106 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants