Wait at end of ehal 0.2 blocking SPI writes #743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discovered while tracking down an issue with the PyGamer display identified here - basically for non-duplex SPIs, the embedded-hal 0.2 blocking writes were returning as soon as the last word was written to the SERCOM, not waiting until it had been shifted out. This resulted in the command/data line for the LCD controller being toggled out of sync with the SPI data stream.
I've tested this only with the PyGamer example.
Checklist
CHANGELOG.md
for the BSP or HAL updated#[allow]
certain lints where reasonable, but ideally justify those with a short comment.