Upgrade pygamer BSP display driver and graphics dependencies
#777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing. I'll revisit this after #772 merges |
sajattack
approved these changes
Nov 9, 2024
sajattack
requested changes
Nov 9, 2024
|
Oh that was done in another pr? |
sajattack
previously approved these changes
Nov 9, 2024
jbeaurivage
reviewed
Nov 9, 2024
Yep, already taken care of! |
kyp44
force-pushed
the
pygamer-upgrade-graphics
branch
2 times, most recently
from
6bb2cfb to
7195ddf
Compare
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Nov 11, 2024
* Changes the `DisplayError` to an enum with variants to provide more detail about why the display driver initialization failed. * Exposes the `dma` and `max-channels` HAL features in the BSP for convenience. * Adds a `cortex_m::asm::wfi()` call inside the terminal infinite loop in the examples to address the `empty_loop` clippy lint.
* Upgrades the display and graphics dependencies: st7735-lcd, embedded-graphics, tinybmp * This completes the upgrades of all dependencies. * Corrects the README.md to list `pygamer` as a `samd51j` BSP instead of the erroneous `same53j`. * Adds an empty `DisplayError` and a `DisplayDriver` type alias, both to address clippy lints.
* Changes the `DisplayError` to an enum with variants to provide more detail about why the display driver initialization failed. * Exposes the `dma` and `max-channels` HAL features in the BSP for convenience. * Adds a `cortex_m::asm::wfi()` call inside the terminal infinite loop in the examples to address the `empty_loop` clippy lint.
kyp44
force-pushed
the
pygamer-upgrade-graphics
branch
from
8bd22af to
7a4c4cb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most of the
pygamerBSP dependencies were upgraded with #766, which was merged. The remaining dependencies are upgraded to the latest version with this PR:st7735-lcdto v0.10.0embedded-graphicsto v0.8.1tinybmpto v0.6Important Note
These dependency upgrades depend on #772, which has already been merged into the
pygamer-upgrade-graphicsbranch but not yet intomaster. Hence, this PR should probably not be merged until #772 has been merged first.Checklist
#[allow]certain lints where reasonable, but ideally justify those with a short comment.