Standardize control-plane node label value specification

[intlabs]

Is this a bug report or feature request?: Mixed; depends on perspective

Kubernetes Version (output of kubectl version): N/A

Helm Client and Tiller Versions (output of helm version): N/A

Development or Deployment Environment?: N/A

Release Tag or Master: Master

Expected Behavior: As a developer and operator, it would be desirable to have standard control-plane node selector keys in the values.yaml. Currently, Nova uses a different set of keys for this functionality.

What Actually Happened: While editing charts, we cannot use the same standardized manifest for jobs as a result of some inconsistency with the way these values are specified.

How to Reproduce the Issue (as minimally as possible): N/A

Any Additional Comments: I suspect the values used in Nova are perfectly acceptable, and we should consider rolling this out to be the standard labeling for all charts. See the following for an example of how these currently differ:

• Nova
  • manifest template
  • values
• Keystone (and other charts)
  • manifest template
  • values

[renmak]

@v1k0d3n @alanmeadows
I can take on this.

So just to clarify, nova uses proper label key and value
control_node_selector_key: @openstack-control-plane
control_node_selector_value: enabled

This change should be rolled out to other charts. This is basically find and replace occurrence of
node_selector_key: openstack-control-plane
node_selector_value: enabled

Please confirm. Thanks

[intlabs]

@renmak That naming convention works for me. Note that Neutron will also need some work to bring it in line as well.