Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing file descriptors can affect capturing subcommand output #198

Closed
krader1961 opened this issue Dec 7, 2017 · 0 comments
Closed

Closing file descriptors can affect capturing subcommand output #198

krader1961 opened this issue Dec 7, 2017 · 0 comments
Assignees
@krader1961
Labels
bug
Milestone
next-minor

Comments

@krader1961
Copy link
Contributor

This was reported as rhbz#1116072. I'm copying it here for clarity because the original bug report (especially the test case) is wrong about several points. Also, the Redhat fix has multiple problems and only fixes the problem accidentally and even then only for the specific test case in rhbz#1116072 not other variations of that test case.
@krader1961 krader1961 added the bug label Dec 7, 2017
@krader1961 krader1961 added this to the next-minor milestone Dec 7, 2017
@krader1961 krader1961 self-assigned this Dec 7, 2017
@krader1961 krader1961 mentioned this issue Dec 8, 2017
Closed
citrus-it added a commit to citrus-it/ast that referenced this issue Dec 30, 2020
@citrus-it
Pick an unused fd to capture subshell output
5224b74 
att#198
citrus-it added a commit to citrus-it/ast that referenced this issue Dec 30, 2020
@citrus-it
Pick an unused fd to capture subshell output
7896fbd 
att#198
citrus-it added a commit to citrus-it/ast that referenced this issue Jan 4, 2021
@citrus-it
Pick an unused fd to capture subshell output
b79f10a 
att#198
citrus-it added a commit to citrus-it/ast that referenced this issue Jan 4, 2021
@citrus-it
Pick an unused fd to capture subshell output
021e6d7 
att#198
citrus-it added a commit to citrus-it/ast that referenced this issue Jan 4, 2021
@citrus-it
Pick an unused fd to capture subshell output
bddfc64 
att#198
citrus-it added a commit to citrus-it/ast that referenced this issue Jan 5, 2021
@citrus-it
Pick an unused fd to capture subshell output
ba0221b 
att#198
citrus-it added a commit to citrus-it/ast that referenced this issue Jan 5, 2021
@citrus-it
Pick an unused fd to capture subshell output
68123a8 
att#198
citrus-it added a commit to citrus-it/ast that referenced this issue Jan 8, 2021
@citrus-it
Pick an unused fd to capture subshell output
d017817 
att#198
citrus-it added a commit to citrus-it/ast that referenced this issue Jan 8, 2021
@citrus-it
Pick an unused fd to capture subshell output
7e65abb 
att#198
McDutchie added a commit to ksh93/ksh that referenced this issue Jan 8, 2021
@McDutchie
Replace safe FD fix with Solaris/ksh2020 version (re: 045fe6a)
ab98ec6 
This pulls a new version of sh_iosafefd() from:
https://github.com/oracle/solaris-userland/blob/master/components/ksh93/patches/285-30771135.patch

It was written by Kurtis Rader for ksh2020:
att#198
att#199
It is presumably better than the Red Hat version and also comes
with more regression test cases (although it still doesn't fix
modernish BUG_CSUBSTDO, which remains in the TODO file).

This commit does not go along with other peripheral changes from
that patch, i.e. a different name and location of this function.

src/cmd/ksh93/sh/io.c:
- Replace sh_iosafefd() as above.

src/cmd/ksh93/tests/subshell.sh:
- Add and tweak tests from the patch.
citrus-it added a commit to citrus-it/ast that referenced this issue Jan 16, 2021
@citrus-it
Pick an unused fd to capture subshell output
0fee25d 
att#198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krader1961 krader1961

Labels
bug
Projects
None yet
Milestone
next-minor
Development

No branches or pull requests
1 participant
@krader1961