Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node 18 and fix dependencies #374

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Use Node 18 and fix dependencies #374

merged 3 commits into from
Jun 9, 2023

Conversation

frederikprijck
Copy link
Contributor

Dependabot has updated zonejs to a version it shouldn't. Using node18 shows an error when running npm install. As our CI runs on node 16, the CI didnt catch this error.

This PR:

  • Fixed zonejs to use 0.12.0 instead of 0.13.0
  • Uses node 18.

Fixes #373

@frederikprijck frederikprijck requested a review from a team as a code owner June 9, 2023 08:35
@frederikprijck frederikprijck enabled auto-merge (squash) June 9, 2023 08:37
@frederikprijck frederikprijck merged commit 246fd33 into master Jun 9, 2023
@frederikprijck frederikprijck deleted the fix/373 branch June 9, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm install fails without --legacy-peer-deps
2 participants