-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2042] Fallback option for transactions using cookies #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
commented
Oct 16, 2020
stevehobbsdev
commented
Oct 16, 2020
stevehobbsdev
commented
Oct 16, 2020
stevehobbsdev
commented
Oct 16, 2020
stevehobbsdev
commented
Oct 16, 2020
stevehobbsdev
commented
Oct 16, 2020
frederikprijck
suggested changes
Oct 19, 2020
frederikprijck
suggested changes
Oct 20, 2020
frederikprijck
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new option
useCookiesForTransactions
that causes the SDK to use cookies for transaction data for the authentication flow instead of the default session storage (introduced in 1.12).This PR also patches a couple of unit tests, as well as fills in a couple of integration tests that are useful for testing this scenario, including full login flows that use both session storage and cookies.
I also ran
npm update
for dependencies.References
May fix #590
Testing
Checklist
master