Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2042] Fallback option for transactions using cookies #603

Merged
merged 11 commits into from
Oct 20, 2020

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Oct 16, 2020

Description

This PR adds a new option useCookiesForTransactions that causes the SDK to use cookies for transaction data for the authentication flow instead of the default session storage (introduced in 1.12).

This PR also patches a couple of unit tests, as well as fills in a couple of integration tests that are useful for testing this scenario, including full login flows that use both session storage and cookies.

I also ran npm update for dependencies.

References

May fix #590

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@stevehobbsdev stevehobbsdev added the CH: Added PR is adding feature or functionality label Oct 16, 2020
@stevehobbsdev stevehobbsdev added this to the vNext milestone Oct 16, 2020
@stevehobbsdev stevehobbsdev requested a review from a team October 16, 2020 16:08
@stevehobbsdev stevehobbsdev merged commit a0c7fd1 into master Oct 20, 2020
@stevehobbsdev stevehobbsdev deleted the feature/cookie-transactions branch October 20, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Added PR is adding feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolving authentication with magic links
2 participants