[SDK-3582] Use form-encoded data by default #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
suggested changes
Aug 8, 2022
frederikprijck
suggested changes
Aug 9, 2022
ewanharris
force-pushed
the
feat/SDK-3582
branch
from
f89f17d to
967da7f
Compare
frederikprijck
suggested changes
Aug 16, 2022
src/global.ts
Outdated
Comment on lines
253
to
254
| * **Note:** If you are using Auth0 rules and are sending custom, non-primitive data make sure to verify that your Auth0 Rules continue to work as expected. If they do not, | ||
| * then set this to `false`. |
There was a problem hiding this comment.
I know this was discussed in an earlier review, but seeing this now makes me wonder if this note should be rephrased still, or left out alltogether.
It used to be a note that referred to anyone touching this value. Which means, as long as people didnt change the value of useFormData, the note was irrelevant.
Now, the note is relevant to anyone not setting the value instead.
I think we can drop the note, but ensure we call it out in the migration guide before we release v2. What do you think?
This prevents an error being logged when running the dev server via npm start Co-authored-by: Frederik Prijck <[email protected]>
ewanharris
force-pushed
the
feat/SDK-3582
branch
from
44eb7f6 to
c1bd290
Compare
frederikprijck
approved these changes
Aug 16, 2022
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the
useFormDataproperty to now default to true. Consequently, updates any tests whereuseFormData: truewas previously set to now use the default, and setsuseFormData: falsewhere the assertions on the testcase indicate it should be.Checklist