[SDK-3547] Rename client_id to clientId #956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Renames
client_id
on the public API toclientId
for consistency with the JS ecosystems preference for camelCase, whilst maintaining sendingclient_id
back to Auth0 in requests.For consistencies sake within the codebase, except for
CacheEntry
the cache related code was also updated to useclientId
overclient_id
.CacheEntry
was not migrated to not break existing cached dataThis will require users of this package to rename the property on their side. The diff for this looks like as follows
Auth0Client
constructorcreateAuth0Client
helperThis change also applies to the
buildLogoutUrl
andlogout
methods onAuth0Client
.However, if you are implementing a custom cache the
CacheEntry
structure still maintains the snakecaseclient_id
for backwards compatibility with existing cached data so there is no migration needed for custom cache implementations.Checklist