-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
afterCallback Hook [SDK-1728] #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Function for custom callback handling after receiving tokens and before redirecting * This can be used for handling token storage, making userinfo calls, claim validation, throwing errors, etc
davidpatrick
force-pushed
the
afterCallbackHook
branch
from
December 16, 2020 01:43
b851983
to
b2bd1fe
Compare
adamjmcgrath
suggested changes
Dec 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of comments
panva
suggested changes
Dec 17, 2020
adamjmcgrath
approved these changes
Dec 22, 2020
davidpatrick
added a commit
that referenced
this pull request
Jan 13, 2021
**Added** - afterCallback Hook [#168](#168) ([davidpatrick](https://github.com/davidpatrick)) **Changed** - Move transient cookies into single cookie [#171](#171) ([davidpatrick](https://github.com/davidpatrick))
Merged
davidpatrick
added a commit
that referenced
this pull request
Jan 14, 2021
**Added** - afterCallback Hook [#168](#168) ([davidpatrick](https://github.com/davidpatrick)) **Changed** - Move transient cookies into single cookie [#171](#171) ([davidpatrick](https://github.com/davidpatrick))
davidpatrick
added a commit
that referenced
this pull request
Jan 14, 2021
**Added** - afterCallback Hook [#168](#168) ([davidpatrick](https://github.com/davidpatrick)) **Changed** - Move transient cookies into single cookie [#171](#171) ([davidpatrick](https://github.com/davidpatrick))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an afterCallback to allow the user to cover the following usecases: