allow configuration of same site attribute on auth_verification cookie #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
suggested changes
Feb 4, 2022
lib/config.js
Outdated
| @@ -45,6 +45,14 @@ const paramsSchema = Joi.object({ | |||
| .maxArity(1) | |||
| .optional() | |||
| .default(() => defaultSessionIdGenerator), | |||
| verificationCookie: Joi.object({ | |||
There was a problem hiding this comment.
Since the transaction cookie isn't strictly part of the session, can we move this config up to the root.
Also, I'm going to need to think about if other properties need to be configurable.
Also, can we call it transactionCookie
There was a problem hiding this comment.
Renamed it. I kept it in object format to allow for more options, but/since I'm unsure if there's currently a use case for modifying the other cookie settings.
adamjmcgrath
approved these changes
Feb 11, 2022
|
Thanks @BitPatty - will merge shortly |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a breaking change.Allows to use a custom same site configuration for theauth_verificationcookie. I only included the override of the samesite but it could be extended later on.References
#322
Testing
Checklist
master