Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3111] Add Oauth error props to http error when available #328

Merged
merged 2 commits into from
Feb 14, 2022
Merged

[SDK-3111] Add Oauth error props to http error when available #328

merged 2 commits into from
Feb 14, 2022

Conversation

adamjmcgrath
Copy link
Contributor

Description

Add the OAuth error and error_description properties to the BadRequest error (via custom properties) when they're available

References

fixes #301

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added the review:small Small review label Feb 11, 2022
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner February 11, 2022 16:26
@adamjmcgrath adamjmcgrath merged commit 65bd19e into master Feb 14, 2022
@adamjmcgrath adamjmcgrath deleted the oauth-error-props branch February 14, 2022 17:13
@adamjmcgrath adamjmcgrath mentioned this pull request Feb 17, 2022
Merged
@alexopenkowski-the-nu-company alexopenkowski-the-nu-company mentioned this pull request Feb 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling errors thrown in callback
2 participants
@adamjmcgrath @stevehobbsdev