Add body parser to login and callback route #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles body parsing on the login route
joshcanhelp
suggested changes
Nov 12, 2019
There was a problem hiding this comment.
@davidpatrick - We'll either need to add body-parser to the package.json file or, if we're OK with the minimum version of Express being 4.16, we can pull it off of express. It looks like we're requiring express in the middleware so I don't think that will be a problem:
https://github.com/auth0/express-openid-connect/blob/master/middleware/auth.js#L44
maybe we can say:
const {urlencoded: expressUrlencoded} = require('express');
joshcanhelp
approved these changes
Nov 19, 2019
joshcanhelp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles body parsing on the login route