Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-1087] Fix case where APP_SESSION_SECRET is set and appSession is not #74

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented Mar 17, 2020

Description

The simple case with env vars

# .env
ISSUER_BASE_URL=https://YOUR_DOMAIN
CLIENT_ID=YOUR_CLIENT_ID
BASE_URL=https://YOUR_APPLICATION_ROOT_URL
APP_SESSION_SECRET=LONG_RANDOM_VALUE
const { auth } = require("express-openid-connect");
app.use(auth());

Was throwing Error: "appSession" is required

Testing

Run the simple case with environmental variables https://github.com/auth0/express-openid-connect#getting-started

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • [ ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath requested review from joshcanhelp and a team March 17, 2020 15:14
@adamjmcgrath adamjmcgrath added the review:small Small review label Mar 17, 2020
@adamjmcgrath adamjmcgrath changed the title Fix case where APP_SESSION_SECRET is set and appSession is not [SDK-1087] Fix case where APP_SESSION_SECRET is set and appSession is not Mar 17, 2020
@adamjmcgrath adamjmcgrath merged commit a2ef34e into master Mar 25, 2020
@adamjmcgrath adamjmcgrath deleted the simple-case-with-env-vars branch July 17, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants