Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default session duration to 1 day #80

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented Mar 27, 2020

Description

Our security review suggested that 7 days for the app session cookie to expire is perhaps a little long for a default.

I had a look around, well just at auth0-spa-js, and noticed that uses 1 day.

Since the auth server handles the underlying session, it shouldn't noticeably effect user experience.

References

https://auth0team.atlassian.net/wiki/spaces/SDL/pages/588286390/express-openid-connect+SDK#Security-Misconfiguration

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath requested a review from a team March 27, 2020 17:18
@adamjmcgrath adamjmcgrath added the review:small Small review label Mar 27, 2020
@lbalmaceda
Copy link
Contributor

Yes! 🎉

@adamjmcgrath adamjmcgrath merged commit 9791633 into master Mar 30, 2020
@adamjmcgrath adamjmcgrath deleted the 1-day-session-duration branch March 30, 2020 09:33
@YousefED
Copy link

YousefED commented May 2, 2020

@adamjmcgrath can you explain Since the auth server handles the underlying session, it shouldn't noticeably effect user experience.? Won't the value of 1 day mean all users have to re-login after 1 day?

@adamjmcgrath
Copy link
Contributor Author

@YousefED If the user is already logged in with their identity provider, the authorize call will just redirect them back to the application with the credentials, without requiring them to login.

@YousefED
Copy link

YousefED commented May 4, 2020

@YousefED If the user is already logged in with their identity provider, the authorize call will just redirect them back to the application with the credentials, without requiring them to login.

Thanks @adamjmcgrath. Makes sense. Does that also count for auth0 Database username / password provider? Which setting in Auth0 handles the session time on that side?

@adamjmcgrath
Copy link
Contributor Author

adamjmcgrath commented May 7, 2020

Hey @YousefED

Does that also count for auth0 Database username / password provider?

Yes, it should do

Which setting in Auth0 handles the session time on that side?

In your tenant settings under "Advanced" - there's a section called "Log In Session Management"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants