[SDK-3150] Serialize dates in collections as seconds since epoch #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just had a comment about the docs. If we want to handle this in the separate docs task, that will make sense as well. Other than that this looks great 👍 |
poovamraj
requested changes
Mar 4, 2022
jimmyjames
force-pushed
the
fix-date-serialization-in-collections
branch
from
2e93c13 to
f3c4192
Compare
poovamraj
pushed a commit
that referenced
this pull request
Mar 16, 2022
* [SDK-3150] Serialize dates in collections as seconds since epoch * cleanup tests * Update javadocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that
Dateclaim values are serialized as seconds since the epoch, as specified by RFC 7519. It also updates the JavaDocs for Date-based claim creation inJWTCreator, to more accurately define how Date-based claims are written to the resulting JSON.The change is marked as breaking change due to the behavioral nature of this fix; clients relying upon the existing behavior will need to be updated to account for this change.