[SDK-3149] Add Instant support #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
force-pushed
the
add-instant-support
branch
from
0f670fb to
4e95a93
Compare
jimmyjames
changed the title
poovamraj
pushed a commit
that referenced
this pull request
Mar 16, 2022
* [SDK-3149] Add support for java.time.Instant * formatting fixes * add javadocs * remove custom Instant claim verification check (not yet supported) * add tests for default method implementations * fix NullClaimTest for asInstant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
🕐 Adds support for
java.time.Instant🕐This PR adds support for
java.time.Instantfor creating and verifying JWTs. Key points to note:Instantsupport is added toDatefunctionality; customers usingDatecan continue to do so.DatemethodsInstantfor its improved functionalityNote: This PR does not include support for custom claim validation of type
Instant. A separate PR will add support for this as well as address the current issue ofDate-based claim validation not accounting for date/time claims being serialized as seconds since the epoch.References
https://docs.oracle.com/javase/8/docs/api/java/time/Instant.html
Testing
Existing unit tests provide good coverage, and tests added for new methods