[SDK-3171] Fix header claims serialization #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poovamraj
reviewed
Mar 16, 2022
| @Override | ||
| public void serialize(T holder, JsonGenerator gen, SerializerProvider provider) throws IOException { | ||
| gen.writeStartObject(); | ||
| holder.getClaims().forEach((key, val) -> System.out.println(key + ": " + val)); |
There was a problem hiding this comment.
I guess we need to remove this
There was a problem hiding this comment.
good catch, new commit added to remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, we serialize the header claims using Jackson's default
writeString. This causes date-time based claims to be serialized as milliseconds since the epoch, instead of the required seconds since the epoch.This PR refactors much of the logic of the
PayloadSerializerout to a new classClaimsSerializer, which allows a subclass to override how the claim is written (needed to handle theaudclaim serialization for the payload).