Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: Use class names for app() calls #291

Merged
merged 2 commits into from
Jun 16, 2022
Merged

change: Use class names for app() calls #291

merged 2 commits into from
Jun 16, 2022

Conversation

evansims
Copy link
Member

@evansims evansims commented Jun 10, 2022 •
edited
Loading

Changes

This PR:

  • Updates our calls to the Laravel app() method to reference our own SDK. While the string approach works, there is potential for conflicts if that string gets inadvertently overwritten by the host application. This change ensures we're always referencing the correct class.
  • Introduces minor code optimizations to fix linter warnings breaking CI.

Contributor Checklist

@evansims evansims added this to the 7.1.0 milestone Jun 10, 2022
@evansims evansims changed the title change: Use classes instead for app() calls change: Use class names for app() calls Jun 10, 2022
@evansims evansims marked this pull request as ready for review June 10, 2022 17:41
@evansims evansims requested a review from a team as a code owner June 10, 2022 17:41
@evansims evansims merged commit c43f664 into main Jun 16, 2022
@evansims evansims deleted the change/use-class-names-for-app-calls branch June 16, 2022 18:12
@evansims evansims mentioned this pull request Aug 9, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@evansims