Merge pull request #1654 from auth0/fix/empty-password-submit

Prevent form submit when password is empty
auth0 · May 23, 2019 · b21499d · b21499d
2 parents 94da80e + e3b42dc
commit b21499d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/__tests__/field/password.test.js b/src/__tests__/field/password.test.js
@@ -8,6 +8,10 @@ describe('field/password', () => {
     passwordField = require('field/password');
   });
   describe('validatePassword()', () => {
+    it(`returns false when there is no password`, () => {
+      const value = passwordField.validatePassword('');
+      expect(value).toBe(false);
+    });
     it(`returns true when there is no policy`, () => {
       const value = passwordField.validatePassword('the-password');
       expect(value).toBe(true);

diff --git a/src/field/password.js b/src/field/password.js
@@ -2,6 +2,9 @@ import PasswordPolicy from 'password-sheriff/lib/policy';
 import { setField } from './index';
 
 export function validatePassword(password, policy) {
+  if (!password) {
+    return false;
+  }
   if (!policy) {
     return true;
   }