Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

languageDictionary title property only displays on "login" tab #1453

Closed
Jack000 opened this issue Jul 28, 2018 · 3 comments · Fixed by #1457
Closed

languageDictionary title property only displays on "login" tab #1453

Jack000 opened this issue Jul 28, 2018 · 3 comments · Fixed by #1457

Comments

@Jack000
Copy link

Jack000 commented Jul 28, 2018 •
edited
Loading

in lock 11.8.0 the customized title only appears for "login", it doesn't seem to change for the "signup" tab.

I've made a minimal page to reproduce the issue at https://app.brandmark.io/v2/lock-test.html
the title says "Sign Up" instead of "my custom title" until you click the login tab.

tested on osx/chrome.

edit: lock 10 had the correct behavior

<html>
<head>
<title>test</title>
</head>
<body>
<div id="auth0"></div>

<script src="https://cdn.auth0.com/js/lock/11.8.0/lock.min.js"></script>
<script>
window.lock = new Auth0Lock('2yt-Sc9Cv425g3KjjAu89GHbMsym9uqi', 'brandmark.auth0.com', {
container: 'auth0',
auth: {
  redirect: false,
  responseType: 'token',
  redirectUrl: 'https://app.brandmark.io/v2/callback.php',
  params: {
    scope: 'openid profile email'
  }
}
});
window.onload = function(){
    window.lock.show({
      initialScreen: 'signUp',
      languageDictionary: {
        title: "my custom title"
      }
    });
}
</script>
</body>
</html>
@luisrudge
Copy link
Contributor

Hi! We fixed the behavior of how the title is shown because it was super inconsistent. There's a great explanation here: #1286

@Jack000
Copy link
Author

Jack000 commented Jul 30, 2018

oh I see what the problem was - the capitalization of "signup" is inconsistent. I had assumed they were all "signUp":

on https://github.com/auth0/lock/blob/master/src/i18n/en.js

signupTitle: 'Sign Up',
signUpLabel: 'Sign Up',
signUpSubmitLabel: 'Sign Up'

@luisrudge
Copy link
Contributor

Oh, wow. That's terrible. It sucks that we can't fix this without a breaking change. I'll patch it up so you can use both signupTitle and signUpTitle

@luisrudge luisrudge mentioned this issue Jul 30, 2018
Merged
luisrudge added a commit that referenced this issue Jul 30, 2018
@luisrudge
Fix/sign up title inconsistenty (#1457)
7178d62 
fix #1453 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/sign up title inconsistenty auth0/lock
2 participants
@luisrudge @Jack000