Add analytics events #1036

francocorreasosa · 2017-06-15T19:37:17Z

Implemented:

Show Forgot Password (forgot_password ready)
Submit Login (signin submit)
Submit Register (register submit)
Submit Forgot Password (forgot_password submit)
Submit OAuth connection (federated login)

Note: federated login will bring an object with more specific info about the event.

{
  name: string, // connection name
  strategy: string, // example: 'facebook', 'twitter', etc...
  action: string // 'signin' or 'signup'
}

Resolve #1028

…ed' as throws test-env-only error (provider.toJS) is not a function.

ntotten · 2017-06-15T20:11:12Z

src/core.js

+      'signin submit',
+      'signup submit',
+      'forgot_password submit',
+      'last_login ready',


this array is exposed via lock.validEvents. if we remove this, the analytics script may not work as expected. (we use this to check if an event is available or not)

ntotten · 2017-06-15T20:11:17Z

src/core.js

+      'signup submit',
+      'forgot_password submit',
+      'last_login ready',
+      'mfa_login ready'


ntotten · 2017-06-15T20:24:50Z

.vscode/tags

+!_TAG_FILE_SORTED	1	/0=unsorted, 1=sorted, 2=foldcase/
+!_TAG_PROGRAM_AUTHOR	Darren Hiebert	/[email protected]/
+!_TAG_PROGRAM_NAME	Exuberant Ctags	//
+!_TAG_PROGRAM_URL	http://ctags.sourceforge.net	/official site/


what is this?

hzalaz · 2017-06-19T16:10:10Z

src/connection/database/reset_password.jsx

@@ -5,6 +5,7 @@ import { authWithUsername, hasScreen } from './index';
 import { cancelResetPassword, resetPassword } from './actions';
 import { renderPasswordResetConfirmation } from './password_reset_confirmation';
 import * as i18n from '../../i18n';
+import * as l from '../../core/index';


do we need this?

hzalaz · 2017-06-19T16:12:33Z

src/field/social/social_buttons_pane.jsx

@@ -6,6 +6,16 @@ import { logIn } from '../../quick-auth/actions';
 import { displayName, socialConnections, authButtonsTheme } from '../../connection/social/index';

 export default class SocialButtonsPane extends React.Component {
+  handleAuthButtonClick(lock, provider, isSignUp) {
+    const prov = typeof provider !== 'object' ? provider.toJS() : provider;


Do we need all values of the connection? Can we just send what type of strategy it is?

Its technically possible to have multiple strategies of the same type though, right? Thats why we were thinking of getting the name as well as the strategy. We dont need all the properties though.

Can you specify what properties to keep? I'll work on this in a few minutes

You can have multiples connection names per strategy for enterprise (for social it might not be that common) But with connection name and strategy will be enough.

Perfect, thanks 👍

hzalaz · 2017-06-19T16:17:07Z

src/field/social/social_buttons_pane.jsx

@@ -6,6 +6,16 @@ import { logIn } from '../../quick-auth/actions';
 import { displayName, socialConnections, authButtonsTheme } from '../../connection/social/index';

 export default class SocialButtonsPane extends React.Component {
+  handleAuthButtonClick(lock, provider, isSignUp) {


Can we move this method outside the class?

Do you mean in the same file, out of the class?

hzalaz · 2017-06-19T18:25:57Z

Also @francocorreasosa @ntotten some tests that the event is correctly emitted with be good

luisrudge · 2017-06-19T18:54:48Z

@francocorreasosa it'd be good to add an entry in the readme about the events as well

francocorreasosa · 2017-06-19T19:41:41Z

README.md

+- `forgot_password submit`: emitted when the user clicks on the submit button of the "Forgot password" screen.
+- `signin submit`: emitted when the user clicks on the submit button of the "Login" screen.
+- `signup submit`: emitted when the user clicks on the submit button of the "Register" screen.
+- `federated login`: emitted when the user clicks on a social connection button. Has the connection name and the strategy as arguments. 



@luisrudge Is this fine?

"Sign up" is better

luisrudge · 2017-06-19T22:02:41Z

README.md

+- `forgot_password ready`: emitted when the "Forgot password" screen is shown.
+- `forgot_password submit`: emitted when the user clicks on the submit button of the "Forgot password" screen.
+- `signin submit`: emitted when the user clicks on the submit button of the "Login" screen.
+- `signup submit`: emitted when the user clicks on the submit button of the "Register" screen.


better to use "Signup" screen here

…social button class.

ntotten

Looks good to me

ntotten · 2017-06-21T16:15:28Z

@luisrudge @hzalaz Looks like all the feedback is resolved. Could we get this merged? :)

Franco Correa added 3 commits June 15, 2017 16:01

Implement events for Analytics

6abe800

Remove npm@5 lockfile

47bc647

Merge master changes into add-analytics-events

796c8b8

francocorreasosa mentioned this pull request Jun 15, 2017

Add additional events for analytics #1028

Closed

5 tasks

Franco Correa added 5 commits June 15, 2017 17:07

Remove mfa_login and last_login events

b5e5b14

Reimplement submit events in SubmitButton

dbb2d2a

Implement 'forgot_password submit' event

70fa832

Implement 'federated login' event with data.

9847d7f

Skip 'calls logIn with social connection 1 when first button is click…

60dc7ca

…ed' as throws test-env-only error (provider.toJS) is not a function.

francocorreasosa changed the title ~~WIP: Add analytics events~~ Add analytics events Jun 16, 2017

Unskip previously skipped tests.

8d2b035

francocorreasosa changed the title ~~Add analytics events~~ Add analytics events #1028 Jun 16, 2017

francocorreasosa changed the title ~~Add analytics events #1028~~ Add analytics events Jun 16, 2017

Remove vscode tags file

b1ecd1c

ntotten approved these changes Jun 19, 2017

View reviewed changes

hzalaz suggested changes Jun 19, 2017

View reviewed changes

Add new events to the readme and fix 'federated login' parameters

740976a

francocorreasosa commented Jun 19, 2017

View reviewed changes

luisrudge suggested changes Jun 19, 2017

View reviewed changes

Franco Correa added 2 commits June 20, 2017 16:00

Change readme signup event reference, move event emmiter outside the …

a42bfdf

…social button class.

Improve event emitting handler

17a42ec

ntotten approved these changes Jun 20, 2017

View reviewed changes

Update README.md

c65ca34

luisrudge previously approved these changes Jun 21, 2017

View reviewed changes

luisrudge dismissed their stale review via 36b0cd4 June 21, 2017 17:28

Update reset_password.jsx

36b0cd4

hzalaz approved these changes Jun 21, 2017

View reviewed changes

luisrudge added this to the v10-Next milestone Jun 21, 2017

luisrudge added the CH: Added label Jun 21, 2017

luisrudge merged commit 75dcc4c into auth0:master Jun 21, 2017

luisrudge mentioned this pull request Jun 22, 2017

EXCEPTION: Invalid event "signin submit"...... #1041

Closed

gene1wood mentioned this pull request Aug 10, 2017

Fix expensify login when triggered through expensify's url by updating auth0 lock mozilla-iam/auth0-deploy#142

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add analytics events #1036

Add analytics events #1036

francocorreasosa commented Jun 15, 2017 •

edited

Loading

ntotten Jun 15, 2017

francocorreasosa Jun 19, 2017 •

edited

Loading

ntotten Jun 15, 2017

ntotten Jun 15, 2017

hzalaz Jun 19, 2017

hzalaz Jun 19, 2017

ntotten Jun 19, 2017

francocorreasosa Jun 19, 2017

hzalaz Jun 19, 2017

francocorreasosa Jun 19, 2017

hzalaz Jun 19, 2017

francocorreasosa Jun 19, 2017

hzalaz commented Jun 19, 2017

luisrudge commented Jun 19, 2017

francocorreasosa Jun 19, 2017

luisrudge Jun 20, 2017

luisrudge Jun 19, 2017

ntotten left a comment

ntotten commented Jun 21, 2017

Add analytics events #1036

Add analytics events #1036

Conversation

francocorreasosa commented Jun 15, 2017 • edited Loading

Choose a reason for hiding this comment

francocorreasosa Jun 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hzalaz commented Jun 19, 2017

luisrudge commented Jun 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ntotten left a comment

Choose a reason for hiding this comment

ntotten commented Jun 21, 2017

francocorreasosa commented Jun 15, 2017 •

edited

Loading

francocorreasosa Jun 19, 2017 •

edited

Loading