Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed translations for Romanian and Slovenian #1092

Merged
merged 2 commits into from
Aug 22, 2017
Merged

Fixed translations for Romanian and Slovenian #1092

merged 2 commits into from
Aug 22, 2017

Conversation

AdrianSima
Copy link
Contributor

  • swapped Romanian and Slovenian translations
  • fixed a few strings for Romanian translation

@AdrianSima
fix Romanian translation
3993f21 
- this file was actually containing the Slovenian translation, while sl.js was containing the Romanian translation.
- fixed a few strings
@AdrianSima
moved the correct translation
86bb593 
This file was actually containing the Romanian translation, while ro.js was containing the Slovenian translation.
@luisrudge
Copy link
Contributor

Can you explain what happened?

@AdrianSima
Copy link
Contributor Author

I got here because I get an error when setting "language = 'ro'" on the Hosted Pages for the Lock widget.
After looking in the file 'src/i18n/ro.js' I saw that it was actually the wrong language. After using Goggle Translate, found out that it was the Slovenian one.

Then I went to 'src/i18n/sl.js' and found the Romanian translation there. I did a fork to swap those contents and while at it fixed a few strings for the Romanian language.

@luisrudge
Copy link
Contributor

Thanks! That make sense. Not sure why languages were switched.

@luisrudge luisrudge merged commit e00161b into auth0:master Aug 22, 2017
@luisrudge luisrudge changed the title Fixed misplaced translations for Romanian and Slovenian Fixed translations for Romanian and Slovenian Aug 22, 2017
@luisrudge luisrudge added this to the v10-Next milestone Aug 22, 2017
@luisrudge luisrudge mentioned this pull request Aug 24, 2017
Merged
@jogee
Copy link
Contributor

jogee commented Aug 30, 2017

Must've mixed them up in the process, not a native speaker, sorry for the confusion.

@brgrz
Copy link
Contributor

brgrz commented Nov 14, 2017 •
edited
Loading

However, the Slovenian translations are missing Slovenian special charasters (like š,č,ž). I thought it was a html charset issue (I always set it to uft-8) but apparently the characters are actually missing in the translation file.

@brgrz
Copy link
Contributor

brgrz commented Nov 14, 2017

Made another fix to the Slovenian translations, please approve and merge

#1171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisrudge luisrudge luisrudge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AdrianSima @luisrudge @jogee @brgrz